Skip to content

support AWS::Type::AppSync::FunctionConfiguration in artifact_exporter#3883

Merged
kyleknap merged 3 commits intoaws:developfrom
groundbreaker:develop
Feb 21, 2019
Merged

support AWS::Type::AppSync::FunctionConfiguration in artifact_exporter#3883
kyleknap merged 3 commits intoaws:developfrom
groundbreaker:develop

Conversation

@xentek
Copy link
Contributor

@xentek xentek commented Jan 22, 2019

Adds support to artifact_exporter for the new CloudFormation type AWS::Type::AppSync::FunctionConfiguration (specifically the RequestMappingTemplateS3Location ResponseMappingTemplateS3Location properties).

There was already an existing PR (#3822) but it hasn't seen any activity for over 25 days. This PR improves upon the original by adding tests for not only the AppSyncFunctionConfigurationRequestTemplateResource and AppSyncFunctionConfigurationResponseTemplateResource classes, which were introduced in this pull but also tests for AppSyncResolverRequestTemplateResource and AppSyncResolverResponseTemplateResource that were introduced in a previous change.

fixes #3816

@xentek xentek mentioned this pull request Jan 22, 2019
Merged
@xentek
Copy link
Contributor Author

xentek commented Jan 23, 2019

@jfuss @justnance this patch should be ready for review. cheers!

@xentek
Copy link
Contributor Author

xentek commented Jan 30, 2019

@jfuss @justnance sorry to be a pest, but any chance this could be reviewed and merged? thanks!

@jfuss
Copy link

jfuss commented Jan 30, 2019

@xentek I am not a maintainer of this repo and therefore have don't have control over commits.

@xentek
Copy link
Contributor Author

xentek commented Feb 13, 2019

@sanathkr @justnance Just updated this PR with the latest from aws/aws-cli@develop. Any chance we can merge this soon so I don't have to continue to maintain and use my fork in my own workflow?

Thanks!

@codecov-io
Copy link

codecov-io commented Feb 13, 2019 •
edited
Loading

Codecov Report

Merging #3883 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3883      +/-   ##
===========================================
+ Coverage    94.44%   94.45%   +<.01%     
===========================================
  Files          187      187              
  Lines        14071    14079       +8     
===========================================
+ Hits         13290    13298       +8     
  Misses         781      781
Impacted Files Coverage Δ
...customizations/cloudformation/artifact_exporter.py 98.55% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8687c1...591f683. Read the comment docs.

@xentek xentek mentioned this pull request Feb 20, 2019
Merged
6 tasks
kyleknap
kyleknap approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me. Merging.

@kyleknap kyleknap merged commit d645479 into aws:develop Feb 21, 2019
@sharmmoh1983
Copy link

sharmmoh1983 commented Feb 26, 2019

Is aws-package supports AppSync FunctionConfiguration?

@PatMyron
Copy link

PatMyron commented Sep 5, 2020 •
edited
Loading

Is aws-package supports AppSync FunctionConfiguration?

looks like this documentation needs to be updated if so:

aws-cli/awscli/examples/cloudformation/_package_description.rst

Lines 11 to 25 in 286d13a

This command can upload local artifacts referenced in the following places:
- ``BodyS3Location`` property for the ``AWS::ApiGateway::RestApi`` resource
- ``Code`` property for the ``AWS::Lambda::Function`` resource
- ``CodeUri`` property for the ``AWS::Serverless::Function`` resource
- ``DefinitionS3Location`` property for the ``AWS::AppSync::GraphQLSchema`` resource
- ``RequestMappingTemplateS3Location`` property for the ``AWS::AppSync::Resolver`` resource
- ``ResponseMappingTemplateS3Location`` property for the ``AWS::AppSync::Resolver`` resource
- ``DefinitionUri`` property for the ``AWS::Serverless::Api`` resource
- ``Location`` parameter for the ``AWS::Include`` transform
- ``SourceBundle`` property for the ``AWS::ElasticBeanstalk::ApplicationVersion`` resource
- ``TemplateURL`` property for the ``AWS::CloudFormation::Stack`` resource
- ``Command.ScriptLocation`` property for the ``AWS::Glue::Job`` resource
- ``DefinitionS3Location`` property for the ``AWS::StepFunctions::StateMachine`` resource

related: #4029, aws-cloudformation/cfn-lint#608, aws-cloudformation/cfn-lint#1683, aws-cloudformation/cfn-lint#1684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kyleknap kyleknap kyleknap approved these changes

@sanathkr sanathkr sanathkr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add cloudformation package support for AWS::AppSync::FunctionConfiguration

7 participants

@xentek @jfuss @codecov-io @sharmmoh1983 @PatMyron @kyleknap @sanathkr